MA0011: suppress diagnostic when all AppendFormat template arguments are culture-insensitive#1085
Merged
Merged
Conversation
…e culture-insensitive Agent-Logs-Url: https://github.com/meziantou/Meziantou.Analyzer/sessions/cd874975-1da8-47b9-a17f-9bf3a890c81e Co-authored-by: meziantou <509220+meziantou@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix MA0011 reporting for case-insensitive template arguments
MA0011: suppress diagnostic when all AppendFormat template arguments are culture-insensitive
Apr 2, 2026
meziantou
approved these changes
Apr 2, 2026
This was referenced Apr 2, 2026
Merged
This was referenced May 12, 2026
Closed
Closed
Closed
This was referenced May 20, 2026
Closed
Closed
Closed
Closed
Closed
This was referenced May 27, 2026
Closed
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MA0011 was incorrectly flagged on
StringBuilder.AppendFormatcalls where every template argument is culture-insensitive (strings, chars, booleans, positive integers, etc.), becauseCultureSensitiveFormattingContext.IsCultureSensitiveOperationhad no special handling forAppendFormatand defaulted totrue.Changes
CultureSensitiveFormattingContext.cs: AddedAppendFormathandling onStringBuildermirroring the existingstring.Formatlogic — skips the format-string argument, then checks each template argument; returnsfalseif none are culture-sensitive. Handles theparams object[], collection-expression (Roslyn 4.14+), and individual-argument overload shapes.UseIFormatProviderAnalyzerTests.cs: Updated the existingAppendFormat("{0}", 10)test (positive int → not culture-sensitive, no longer warrants a diagnostic; changed to-1); added no-diagnostic cases for"{0} / {1}", "X", "Y"and"{0}", 10.Example
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
st8vsblobprodcus339.vsblob.vsassets.io/usr/share/dotnet/dotnet dotnet restore --no-dependencies /home/REDACTED/work/Meziantou.Analyzer/Meziantou.Analyzer/Meziantou.Analyzer.slnx --packages /tmp/codeql-scratch-8ad8dc5536a632e8/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-8ad8dc5536a632e8/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-8ad8dc5536a632e8/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true(dns block)/usr/share/dotnet/dotnet dotnet restore --no-dependencies /home/REDACTED/work/Meziantou.Analyzer/Meziantou.Analyzer/tests/Meziantou.Analyzer.Test/Meziantou.Analyzer.Test.csproj --packages /tmp/codeql-scratch-8ad8dc5536a632e8/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-8ad8dc5536a632e8/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-8ad8dc5536a632e8/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true(dns block)If you need me to access, download, or install something from one of these locations, you can either: